[UI]: Make sidebards resizable and add local persistence#1098
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces resizable left and right sidebars for the documentation layout, saving the user's preferred widths in localStorage and applying them on page load. The review feedback highlights several important improvements: validating and parsing localStorage values to prevent potential CSS injection, moving the width-loading script to the <head> and removing the defer attribute to prevent layout shifts (FOUC), and adding fallback values in the resizer script to handle cases where CSS custom properties fail to parse as integers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
@banana-three-join Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Bhumikagarggg
left a comment
Bhumikagarggg
left a comment
There was a problem hiding this comment.
The resizable side panel implementation looks useful, but a couple of cleanups are needed before approval:
git diff --checkreports trailing whitespace in the new JS, SCSS, and layout files. Please remove the trailing whitespace.package-lock.jsonappears to have an unrelated reorder-only change for thetypescriptblock. Please revert that file unless this PR intentionally changes dependencies.
banana-three-join
force-pushed
the
feature/banana-three-join/resizable-side-panels
branch
from
47724c0 to
874aba1
Compare
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
banana-three-join
force-pushed
the
feature/banana-three-join/resizable-side-panels
branch
from
874aba1 to
fec1261
Compare
|
@Bhumikagarggg Fixed! |
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
Signed-off-by: Lenox Wiltshire <lenoxwiltshire@gmail.com>
3 participants
Notes for Reviewers
This PR fixes #1039
Behavior showcase:
https://www.loom.com/share/98269b5657e34a9dab9b5ae2613e2954
Signed commits